Skip to content

🎨 💥 Apply consistent naming between callback and flow #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

🎨 💥 Apply consistent naming between callback and flow #646

merged 1 commit into from
Nov 19, 2024

Conversation

elbeno
Copy link
Contributor

@elbeno elbeno commented Nov 18, 2024

Problem:

  • flow constructs are called flow::builder and flow::service.
  • callback constructs are called cib::callback and cib::callback_meta, which is confusing.

Solution:

  • Rename the callback constructs to callback::builder and callback::service to match the flow pattern.

@elbeno
🎨 💥 Apply consistent naming between callback and flow
9525534 
Problem:
- `flow` constructs are called `flow::builder` and `flow::service`.
- `callback` constructs are called `cib::callback` and `cib::callback_meta`, which is
  confusing.

Solution:
- Rename the `callback` constructs to `callback::builder` and
  `callback::service` to match the `flow` pattern.
lukevalenty
lukevalenty approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@lukevalenty lukevalenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it!

@lukevalenty lukevalenty merged commit 775ced5 into intel:main Nov 19, 2024
22 checks passed
@elbeno elbeno deleted the rename-callback-constructs branch November 19, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukevalenty lukevalenty lukevalenty approved these changes

@mjcaisse-intel mjcaisse-intel Awaiting requested review from mjcaisse-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elbeno @lukevalenty